Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts BuildResScheduleFile methods to ruby constants #1814

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Aug 28, 2024

Pull Request Description

Addresses #1759.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Aug 28, 2024
Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically an extension of #1808?

I think my only concern is that perhaps these constants actually should have some documentation. Maybe we accept this PR as-is, but open a new issue requesting documentation and filling in TODOs for:

@shorowit
Copy link
Contributor Author

This is basically an extension of #1808?

Yes, I missed that there were more constants in this measure.

I think my only concern is that perhaps these constants actually should have some documentation. Maybe we accept this PR as-is, but open a new issue requesting documentation and filling in TODOs for:

Agreed that more comments would be useful. Some of the constants may be described in the measure where they get used. Someone who is familiar with the measure definitely needs to take a big cut on it. For now, I added your comment to #1759 so we don't lose track of them.

@shorowit shorowit merged commit 3c53615 into master Aug 28, 2024
7 checks passed
@shorowit shorowit deleted the schedule_contants branch August 28, 2024 18:54
@joseph-robertson joseph-robertson mentioned this pull request Aug 28, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants