Datapoint extrapolation #1904

shorowit · 2024-12-26T21:46:32Z

Pull Request Description

Addresses #1871. Updates datapoint extrapolation per RESNET MINHERS Addendum 82.

Checklist

Not all may apply:

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/defaults.rb # HPXMLtoOpenStudio/tests/test_defaults.rb # docs/source/workflow_inputs.rst

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml

… the RESNET MINHERS Addendum 82 extrapolation rules. [ci skip]

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml

shorowit · 2025-01-07T17:51:35Z

HPXMLtoOpenStudio/resources/hpxml.rb

+          # Check power at minimum capacity <= power at maximum capacity
+          if min_capacity / min_cop > max_capacity / max_cop
+            errors << "Cooling detailed performance data for outdoor temperature = #{outdoor_temp} is invalid; Power (capacity / COP) at minimum capacity must be less than power at maximum capacity."
+          end
+          # Check minimum capacity <= maximum capacity
+          if min_capacity > max_capacity
+            errors << "Cooling detailed performance data for outdoor temperature = #{outdoor_temp} is invalid; Maximum capacity must be greater than minimum capacity."
+          end


Added two checks that RESNET used when filtering the NEEP database for bad data. There could be others that we add, but these are the most important ones.

shorowit · 2025-01-07T17:53:27Z

HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml

      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=47 and h:CapacityDescription="minimum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=47 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature=47 and h:CapacityDescription="maximum"]) = 1'>Expected 1 element(s) for xpath: PerformanceDataPoint[OutdoorTemperature=47 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
-      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=47 and h:CapacityDescription="minimum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=47 and CapacityDescription="minimum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
-      <sch:assert role='ERROR' test='count(h:PerformanceDataPoint[h:OutdoorTemperature!=47 and h:CapacityDescription="maximum"]) &gt;= 1'>Expected 1 or more element(s) for xpath: PerformanceDataPoint[OutdoorTemperature!=47 and CapacityDescription="maximum"]</sch:assert> <!-- See [PerformanceDataPoint] -->
+      <!-- FIXME: Require 17F once our defaulting code adds this data point -->


Our current variable speed HP defaulting code only creates 47F and 5F data points, so 17F is temporarily marked as optional. Once we implement the new RESNET defaulting, we'll update the two lines below to require 17F.

shorowit · 2025-01-07T17:53:50Z

HPXMLtoOpenStudio/resources/hvac.rb

-      is_onoff_thermostat_ddb = hpxml_header.hvac_onoff_thermostat_deadband.to_f > 0.0
+      has_deadband_control = hpxml_header.hvac_onoff_thermostat_deadband.to_f > 0.0


Just trying to use consistent variable names throughout the code.

shorowit · 2025-01-07T17:54:43Z

HPXMLtoOpenStudio/resources/hvac.rb

-        this_cfm = UnitConversions.convert(dp.capacity, 'Btu/hr', 'ton') * cfm_per_ton[speed]
-        fan_ratio = this_cfm / max_rated_fan_cfm
-        fan_power = calculate_fan_power_from_curve(hvac_ap.fan_power_rated * max_rated_fan_cfm, fan_ratio, hvac_system)
-        dp.gross_capacity, dp.gross_efficiency_cop = convert_net_to_gross_capacity_cop(dp.capacity, fan_power, mode, dp.efficiency_cop)
+        convert_data_point_net_to_gross(dp, mode, hvac_system, cfm_per_ton[speed], max_rated_fan_cfm)


Moved this code into a new method so it can be called for other locations too.

shorowit · 2025-01-07T17:56:37Z

HPXMLtoOpenStudio/resources/hvac.rb

+        # Calculate ODB temperature at which power or capacity is zero
+        high_odb_at_zero_power = calculate_odb_at_zero_power_or_capacity(data, user_odbs, :gross_input_power, true)
+        high_odb_at_zero_capacity = calculate_odb_at_zero_power_or_capacity(data, user_odbs, :gross_capacity, true)
+        outdoor_dry_bulbs << [high_odb_at_zero_power, high_odb_at_zero_capacity, hp_temp, weather_temp].min # Max cooling ODB
+
+        low_odb_at_zero_power = calculate_odb_at_zero_power_or_capacity(data, user_odbs, :gross_input_power, false)
+        low_odb_at_zero_capacity = calculate_odb_at_zero_power_or_capacity(data, user_odbs, :gross_capacity, false)
+        outdoor_dry_bulbs << [low_odb_at_zero_power, low_odb_at_zero_capacity, 60.0].max # Min cooling ODB


This didn't really change other than switching from gross_efficiency_cop to gross_input_power, since we are now extrapolating based on input power instead of COP.

shorowit · 2025-01-07T17:57:23Z

HPXMLtoOpenStudio/resources/hvac.rb

+        new_dp.capacity = extrapolate_data_point_to_odb(data, mode, capacity_description, target_odb, :capacity)
+        new_dp.input_power = extrapolate_data_point_to_odb(data, mode, capacity_description, target_odb, :input_power)


We now extrapolate based on net capacity and input power (rather than gross capacity and COP).

shorowit · 2025-01-07T18:00:12Z

HPXMLtoOpenStudio/resources/hvac.rb

    slope = (right_dp.send(property) - left_dp.send(property)) / (right_odb - left_odb)
    val = (target_odb - left_odb) * slope + left_dp.send(property)
+
+    if mode == :clg && target_odb < 82


This handles the extrapolation to 60F for cooling. We can't use target_odb == 60 because we may not extrapolate all the way to 60; if, for example, extrapolation of gross input power becomes negative at a larger ODB temperature, then we only extrapolate to that ODB.

There is an open question to RESNET for the top rule so it may have to change.

shorowit · 2025-01-07T18:00:43Z

HPXMLtoOpenStudio/resources/hvac.rb

+      # FIXME: Need interpretation from RESNET on how this case should be handled
+      dp_82F = data.find { |dp| dp.outdoor_temperature == 82.0 }
+      val = [val, 0.5 * dp_82F.send(property)].max
+    elsif mode == :htg && target_odb > 47


Similar implementation to extrapolate to 60F for heating.

shorowit · 2025-01-07T19:01:43Z

workflow/hpxml_inputs.json

@@ -2201,16 +2201,16 @@
  "sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance-other-temperatures.xml": {
    "parent_hpxml": "sample_files/base-hvac-air-to-air-heat-pump-var-speed-detailed-performance.xml",
    "hvac_perf_data_capacity_type": "Absolute capacities",
-    "hvac_perf_data_heating_outdoor_temperatures": "47.0, 55.0",


55F is no longer allowed and 17F/5F are now required, so I had to update this test file.

shorowit · 2025-01-07T20:52:32Z

@yzhou601 This PR is ready, other than the one test failure:
base-hvac-air-to-air-heat-pump-var-speed-max-power-ratio-schedule-two-systems.xml: [Peak Load: Cooling: Delivered (kBtu/hr), Annual] 1x=228.96999999999997, 10x=195.301, abs_delta_tol=0.2, abs_frac_tol=0.05

…nStudio-HPXML into datapoint_extrapolation

HPXMLtoOpenStudio/resources/hvac.rb

yzhou601 · 2025-01-10T22:51:25Z

@yzhou601 This PR is ready, other than the one test failure: base-hvac-air-to-air-heat-pump-var-speed-max-power-ratio-schedule-two-systems.xml: [Peak Load: Cooling: Delivered (kBtu/hr), Annual] 1x=228.96999999999997, 10x=195.301, abs_delta_tol=0.2, abs_frac_tol=0.05

Should be fixed in the last commit, let's give it a try and I'll review this PR after CI gets green.

shorowit added 3 commits December 26, 2024 14:24

First pass.

3a1c29b

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

c36aa2f

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/defaults.rb # HPXMLtoOpenStudio/tests/test_defaults.rb # docs/source/workflow_inputs.rst

Update Changelog.md

d1b6749

shorowit added the enhancement New feature or request label Dec 26, 2024

shorowit self-assigned this Dec 26, 2024

shorowit added 11 commits December 26, 2024 19:06

Update comment [ci skip]

8a55975

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

85effef

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml

Add capacity & power datapoint checks.

80776d1

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

5a8c811

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml

Simplify extrapolation bounds.

143b37e

Minor code cleanup.

11d271c

Perform extrapolation until values become negative.

3ea0043

Simplify implementation to remove step search [ci skip]

f865e5c

Restrict outdoor temperatures for detailed datapoints so we can apply…

b90c066

… the RESNET MINHERS Addendum 82 extrapolation rules. [ci skip]

Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…

fc63ba3

…-HPXML into datapoint_extrapolation # Conflicts: # HPXMLtoOpenStudio/measure.xml

Fixes some CI failures.

d01e7ff

shorowit mentioned this pull request Jan 7, 2025

Update HP models per RESNET HVAC addendum #1871

Open

15 tasks

shorowit commented Jan 7, 2025

View reviewed changes

shorowit marked this pull request as ready for review January 7, 2025 20:53

shorowit and others added 4 commits January 9, 2025 13:37

Revert max compressor temp input.

631fd33

fix max power program

061a46a

update measure

f3738bb

Merge branch 'datapoint_extrapolation' of https://github.com/NREL/Ope…

63204b7

…nStudio-HPXML into datapoint_extrapolation

yzhou601 reviewed Jan 10, 2025

View reviewed changes

HPXMLtoOpenStudio/resources/hvac.rb Show resolved Hide resolved

Latest results.

4727080

shorowit mentioned this pull request Jan 11, 2025

Bugfix for max power program for variable-speed HVACs #1909

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Datapoint extrapolation #1904

Datapoint extrapolation #1904

shorowit commented Dec 26, 2024 •

edited

Loading

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit Jan 7, 2025

shorowit commented Jan 7, 2025

yzhou601 commented Jan 10, 2025

		is_onoff_thermostat_ddb = hpxml_header.hvac_onoff_thermostat_deadband.to_f > 0.0
		has_deadband_control = hpxml_header.hvac_onoff_thermostat_deadband.to_f > 0.0

		new_dp.capacity = extrapolate_data_point_to_odb(data, mode, capacity_description, target_odb, :capacity)
		new_dp.input_power = extrapolate_data_point_to_odb(data, mode, capacity_description, target_odb, :input_power)

Datapoint extrapolation #1904

Are you sure you want to change the base?

Datapoint extrapolation #1904

Conversation

shorowit commented Dec 26, 2024 • edited Loading

Pull Request Description

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shorowit commented Jan 7, 2025

yzhou601 commented Jan 10, 2025

shorowit commented Dec 26, 2024 •

edited

Loading