Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow array of measures_dir in apply_measures function #1908

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

rajeee
Copy link
Collaborator

@rajeee rajeee commented Jan 9, 2025

Pull Request Description

Update apply_measures function to allow an array of measures_dir because some OSW file needs multiple measures_dir.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@rajeee rajeee requested a review from shorowit January 10, 2025 00:24
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge if the CI is happy. Thanks!

@shorowit shorowit merged commit 0111ed5 into master Jan 10, 2025
@shorowit shorowit deleted the meta_measure_update branch January 10, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants