Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ref wind height to -1 for turboparkgauss.yaml #999

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Oct 15, 2024

Set ref wind height to -1 for turboparkgauss.yaml

Doing some other work I noticed that among the example inputs turboparkgauss.yaml uses 90.0 instead of -1. This isn't really a bug, but since we often use these example inputs as starters for other turbine models, probably nice if they all use the more generic option. I think this is the only case of this (the multiple turbine input correctly specifies the height since there isn't a single height).

@paulf81 paulf81 added the bug Something isn't working label Oct 15, 2024
@paulf81 paulf81 requested a review from misi9170 October 15, 2024 15:29
@paulf81 paulf81 self-assigned this Oct 15, 2024
Copy link
Collaborator

@misi9170 misi9170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this. I'll also use this opportunity to call out the tangentially related #809, which I'm going to update for v4.

@paulf81
Copy link
Collaborator Author

paulf81 commented Oct 15, 2024

I agree with this. I'll also use this opportunity to call out the tangentially related #809, which I'm going to update for v4.

Sounds good! Should I hold this PR and wait for that? Or go ahead and merge?

@misi9170
Copy link
Collaborator

@paulf81 good to merge

@paulf81 paulf81 merged commit d616417 into NREL:develop Oct 15, 2024
8 checks passed
@paulf81 paulf81 deleted the ref_wind_height branch October 15, 2024 17:14
@misi9170 misi9170 mentioned this pull request Oct 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants