fixes for handling LinkIds #211

robfitzgerald · 2023-09-28T21:33:20Z

this PR contains two fixes for buggy behavior surrounding LinkIds:

removes the use of literal_eval in link_id. this was probably intended to coerce values to be an integer, but creates an unnecessary security issue (code injection) and seems to fail with python 3.10 for handling both strings and ints. this is the desired behavior, since Haversine LinkIds are \w+-\w and Osm LinkIds are \d+-\d+.
adds a specialized extract_node_ids_int operation for OSM networks for this exact case
some logging added around building OSM networks

nreinicke

Good call on pulling out the literal_eval, I had forgotten that even existed down there. Everything else looks good too

robfitzgerald added 6 commits September 27, 2023 15:14

remove use of literal_eval

aed1636

helper to extract node ids as integers

a829e91

logging

d20fd5e

avoid built-in "id" name

3b3cd50

split out lines for breakpoints, logging

9eb124b

avoid built-in "id" name

64a7614

robfitzgerald requested a review from nreinicke September 28, 2023 21:33

robfitzgerald added 2 commits September 29, 2023 11:44

out of service instruction

f1fd7af

formatting

4033b3b

nreinicke approved these changes Oct 2, 2023

View reviewed changes

Merge branch 'main' into rjf/remove-eval

dd16f29

robfitzgerald merged commit c353d05 into main Oct 2, 2023
5 checks passed

robfitzgerald deleted the rjf/remove-eval branch October 2, 2023 22:16

Provide feedback