-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Wind Features 2024 #1186
Merged
Merged
New Wind Features 2024 #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del, renamed wake loss variables and outputs for clarity
…ovide additional values
…and updated test accordingly
…r the park wake model. placeholder for functionality of using the input needs to be updated.
…ve to belong to wind turbine class so that it will be available to all wake models
…h a user-defined Ct curve for all wind wake models
…update wake loss output names per Paul suggestions
… needs to be completed
…re than just the timestep triggering the loss
dguittet
reviewed
Jul 30, 2024
dguittet
requested changes
Jul 30, 2024
…e model option and updated tests accordingly
dguittet
reviewed
Oct 14, 2024
dguittet
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a variety of new features to the wind model, currently accessible only programmatically.
New features include:
--also separates "internal" wake losses (i.e. calculated by a wake model) from external wake losses (i.e. from other plants)
Tests have been added to cover these new features.
Bug fix for #1143 included in this PR.
@dguittet I think you're the best reviewer for this, but note that this is not an urgent PR. :) I did not generate the the new API files for these new inputs, but maybe I can get your help with that when you have some time?