STY: fix the style + pylinting

.pre-commit-config.yaml

@@ -10,7 +10,7 @@ repos:
         additional_dependencies: [black==23.*]
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: "v4.5.0"
+    rev: "v4.6.0"
     hooks:
       - id: check-added-large-files
       - id: check-case-conflict
@@ -40,7 +40,7 @@ repos:
         args: [--prose-wrap=always]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.2.1"
+    rev: "v0.4.5"
     hooks:
       - id: ruff
         args: ["--fix", "--show-fixes"]
@@ -56,12 +56,12 @@ repos:
   #         - pytest
 
   - repo: https://github.com/codespell-project/codespell
-    rev: "v2.2.6"
+    rev: "v2.3.0"
     hooks:
       - id: codespell
 
   - repo: https://github.com/shellcheck-py/shellcheck-py
-    rev: "v0.9.0.6"
+    rev: "v0.10.0.1"
     hooks:
       - id: shellcheck
 
@@ -74,13 +74,13 @@ repos:
         exclude: .pre-commit-config.yaml
 
   - repo: https://github.com/abravalheri/validate-pyproject
-    rev: "v0.16"
+    rev: "v0.18"
     hooks:
       - id: validate-pyproject
         additional_dependencies: ["validate-pyproject-schema-store[all]"]
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: "0.28.0"
+    rev: "0.28.4"
     hooks:
       - id: check-dependabot
       - id: check-github-workflows

src/srx_caproto_iocs/__init__.py

@@ -4,7 +4,6 @@
 srx-caproto-iocs: Caproto IOCs for the NSLS-II SRX beamline
 """
 
-
 from __future__ import annotations
 
 from ._version import version as __version__

src/srx_caproto_iocs/axis/__init__.py

@@ -1 +1 @@
-""""Axis Cameras Caproto IOC code."""
+"""Axis Cameras Caproto IOC code."""

src/srx_caproto_iocs/axis/caproto_ioc.py

@@ -1,3 +1,4 @@
+# pylint: disable=duplicate-code
 from __future__ import annotations
 
 import textwrap
@@ -17,8 +18,6 @@
 class AxisSaveIOC(CaprotoSaveIOC):
     """Axis caproto save IOC."""
 
-    common_kwargs = {"max_length": 255, "string_encoding": "utf-8"}
-
     key1 = pvproperty(
         value="",
         string_encoding="utf-8",
@@ -38,9 +37,9 @@ def __init__(self, *args, camera_host=None, **kwargs):
         print(f"{camera_host = }")
         super().__init__(*args, **kwargs)
 
-    async def _get_current_dataset(self, *args, **kwargs):
+    async def _get_current_dataset(self, *args, **kwargs):  # pylint: disable=unused-argument
         url = f"http://{self._camera_host}/axis-cgi/jpg/image.cgi"
-        resp = requests.get(url)
+        resp = requests.get(url, timeout=10)
         img = Image.open(BytesIO(resp.content))
 
         dataset = img
@@ -56,7 +55,6 @@ def saver(request_queue, response_queue):
             filename = received["filename"]
             data = received["data"]
             # 'frame_number' is not used for this exporter.
-            frame_number = received["frame_number"]  # noqa: F841
             try:
                 save_image(fname=filename, data=data, file_format="jpeg", mode="x")
                 print(f"{now()}: saved data into:\n  {filename}")

src/srx_caproto_iocs/base.py

@@ -151,6 +151,7 @@ async def _stage(self, instance, value):
 
     @stage.putter
     async def stage(self, *args, **kwargs):
+        """The stage method."""
         return await self._stage(*args, **kwargs)
 
     async def _get_current_dataset(self, frame):
@@ -244,6 +245,11 @@ class OphydDeviceWithCaprotoIOC(Device):
     def set(self, command):
         """The set method with values for staging and acquiring."""
 
+        expected_old_value = None
+        expected_new_value = None
+        obj = None
+        cmd = None
+
         # print(f"{now()}: {command = }")
         if command in [StageStates.STAGED.value, "stage"]:
             expected_old_value = StageStates.UNSTAGED.value

src/srx_caproto_iocs/example/__init__.py

@@ -1 +1 @@
-""""Example Caproto IOC code."""
+"""Example Caproto IOC code."""

src/srx_caproto_iocs/utils.py

@@ -15,7 +15,8 @@ def now(as_object=False):
     return _now.isoformat()
 
 
-def save_image(fname, data, file_format="jpeg", mode="x"):
+def save_image(fname, data, file_format="jpeg", mode="x"):  # pylint: disable=unused-argument
+    """The function to export the image data (e.g., to a JPEG file."""
     data.save(fname, file_format=file_format)
 
 

src/srx_caproto_iocs/zebra/__init__.py

@@ -1 +1 @@
-""""Zebra Caproto IOC code."""
+"""Zebra Caproto IOC code."""

src/srx_caproto_iocs/zebra/caproto_ioc.py

@@ -1,3 +1,4 @@
+# pylint: disable=duplicate-code
 from __future__ import annotations
 
 import textwrap
@@ -162,9 +163,8 @@ class ZebraSaveIOC(CaprotoSaveIOC):
     #     super().__init__(*args, **kwargs)
     #     self._external_pvs = external_pvs
 
-    async def _get_current_dataset(
-        self, *args, **kwargs
-    ):  # , frame, external_pv="enc1"):
+    async def _get_current_dataset(self, *args, **kwargs):  # pylint: disable=unused-argument
+        # , frame, external_pv="enc1"):
         # client_context = Context()
         # (pvobject,) = await client_context.get_pvs(self._external_pvs[external_pv])
         # print(f"{pvobject = }")
@@ -192,7 +192,6 @@ def saver(request_queue, response_queue):
             filename = received["filename"]
             data = received["data"]
             # 'frame_number' is not used for this exporter.
-            frame_number = received["frame_number"]  # noqa: F841
             try:
                 save_hdf5_zebra(fname=filename, data=data, mode="x")
                 print(f"{now()}: saved data into:\n  {filename}")