-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Zoom 5 (or Zoom N) #312
Draft
vshekar
wants to merge
9
commits into
NSLS-II:master
Choose a base branch
from
vshekar:zoom5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced them with QSlider with labels for extensibility - Callbacks and certain functions related to the buttons now moved to the slider class - Slider class allows other mag levels to be added easily
- Added mousewheel zoom
vshekar
commented
Aug 7, 2023
from gui.control_main import ControlMain | ||
|
||
|
||
class CustomView(QGraphicsView): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created CustomView mainly to handle events that happen when the sample cam is in focus. It handles the following events:
- Using the mouse wheel (connects to
handle_wheel
method ingui.camera.zoom_widget.ZoomSlider
- Detects whether Ctrl key is pressed and the mouse is clicked on the sample cam
- Triggers center_on_click when all conditions above are met
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request that replaces the zoom radio buttons with a zoom slider. The zoom slider is not static and can be modified based on beamline config parameters