Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making NYX Dewar 8x3 #350

Open
wants to merge 126 commits into
base: md2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
126 commits
Select commit Hold shift + click to select a range
af3590c
change call for insertRasterResult to allow remote call
JunAishima Jan 31, 2023
5451785
send insertRasterResult() call to server
JunAishima Jan 31, 2023
698d8b3
remove ispybLib requirement from GUI
JunAishima Jan 31, 2023
0b7f386
fix string output so literals are surrounded with single quotes
JunAishima Feb 1, 2023
f23c86f
no dzdo necessary if all LSDC servers are run by service user
JunAishima Mar 9, 2023
bfe2103
check that an lsdc service user is running the script
JunAishima Mar 23, 2023
7ae433a
Commenting out light brightness button until PVs are fixed
vshekar May 4, 2023
2f5224a
Disabling brighter and dimmer buttons until PV is fixed
vshekar May 4, 2023
b7ab8c2
Fixes:
vshekar May 6, 2023
baa1d1a
Ran black formatter
vshekar May 6, 2023
8f4ab1c
Increased sleep time after loading hdf5 file from 0.3 to 0.5
vshekar May 8, 2023
23648c2
Merge branch 'lifetime-fixes' of https://github.com/vshekar/lsdc into…
vshekar May 8, 2023
7a3c097
Update control_main.py
vshekar May 8, 2023
978159d
Merge pull request #291 from vshekar/remove-light-buttons
vshekar May 8, 2023
1fa9fdf
Merge branch 'master' into lifetime-fixes
vshekar May 8, 2023
a99e762
Merge pull request #292 from vshekar/lifetime-fixes
vshekar May 8, 2023
da7090d
calcLifetime triggers when osc range is edited
vshekar May 11, 2023
ae6b4e3
Merge pull request #293 from vshekar/lifetime-fixes-update
JunAishima May 12, 2023
73f091e
Fixed a case where multiple users write to the same raddose output
vshekar May 19, 2023
7cebe93
Fixed wrong parameters passed to mount function when retrying after e…
vshekar May 25, 2023
67544e5
Added code to save FMX flux reference after setE
vshekar Jun 15, 2023
deec178
all server and GUI instances will be run from lsdc_<tla>_prod
JunAishima Jun 26, 2023
2334267
Merge pull request #299 from JunAishima/centralize-collection-directory
JunAishima Jun 27, 2023
be9ddd0
add current LSDC service users, check current user against them
JunAishima Jun 27, 2023
4c8c30d
use subprocess.Popen which has the cwd kwarg
JunAishima Jun 29, 2023
29e5c7e
Reading lines of subprocess.Popen()
vshekar Jun 29, 2023
4f424d8
Using subprocess.run() instead of subprocess.Popen() in topview.py
vshekar Jun 29, 2023
6a12eae
Merge pull request #304 from JunAishima/fix-popen-cwd
JunAishima Jun 29, 2023
74081de
Added fixes to make bluesky plan work
vshekar Jun 29, 2023
e3b10b0
Merge pull request #301 from NSLS-II/update-lsdc-prod-location
JunAishima Jun 30, 2023
355b38b
Merge pull request #282 from JunAishima/service-user-2023-1
JunAishima Jun 30, 2023
df311bf
Merge remote-tracking branch 'origin/one-branch-to-rule-them-all'
JunAishima Jun 30, 2023
0dcba83
Merge branch 'master' into 2023-2-amxfmx
JunAishima Jun 30, 2023
7a963d6
Merge branch 'master' into one-branch-to-rule-them-all
JunAishima Jun 30, 2023
4d069dd
Merge pull request #307 from NSLS-II/one-branch-to-rule-them-all
JunAishima Jun 30, 2023
a3698d0
Merge branch 'master' into 2023-2-amxfmx
JunAishima Jun 30, 2023
2823afc
Merge pull request #308 from JunAishima/2023-2-amxfmx
JunAishima Jun 30, 2023
b397f72
remove homing pins after sample mount on FMX
JunAishima Mar 3, 2023
6a74183
remove commented-out code for homing pins on FMX
JunAishima Jul 6, 2023
5f219dc
move omega to 0 before SA->SE on FMX
JunAishima May 15, 2023
9a54800
Merge branch 'one-branch-to-rule-them-all' into remove-ispyblib-from-gui
JunAishima Jul 19, 2023
e483951
re-do commits removed after merging gui modularization
JunAishima Jul 19, 2023
4bc82c0
Removed hard coded return statements to properly return robot failures
vshekar Jul 21, 2023
64425a2
Removed unecessary assignment
vshekar Jul 21, 2023
b89c788
Revert "comment out ISPyB calls to database"
JunAishima Jul 25, 2023
3ee4228
Revert "fix for proposal name while ISPyB is down"
JunAishima Jul 25, 2023
e736700
use config from /etc/ispyb
JunAishima Jul 25, 2023
f3653ae
use mysql connector object from ISPyB connection
JunAishima Jul 25, 2023
f1fd622
fix missing parenthesis
JunAishima Jul 25, 2023
df11338
Merge pull request #318 from vshekar/robot-fixes
danielballan Jul 25, 2023
d173a6b
Merge pull request #319 from JunAishima/re-enable-ispyb
JunAishima Jul 26, 2023
b7bce67
Merge branch '2023-2-amxfmx' into remove-ispyblib-from-gui
JunAishima Jul 26, 2023
132306c
Merge pull request #317 from JunAishima/remove-ispyblib-from-gui
JunAishima Jul 26, 2023
36ce2fa
Merge pull request #310 from JunAishima/small-fixes-2023-07-06
JunAishima Jul 31, 2023
19ddc5b
Revert "all server and GUI instances will be run from lsdc_<tla>_prod"
JunAishima Aug 7, 2023
2b429ce
Merge pull request #296 from vshekar/retry-mount-fix
JunAishima Aug 9, 2023
41d7517
initial release notes
JunAishima Aug 14, 2023
d0bb07b
Merge pull request #322 from JunAishima/revert-running-lsdc-in-lsdc-t…
JunAishima Aug 16, 2023
97eb6f0
Removed replaceLine function
vshekar May 19, 2023
26d3de0
Cleanup and formatting
vshekar Jun 29, 2023
43ac2f2
Merge pull request #295 from vshekar/lifetime-fixes
JunAishima Sep 8, 2023
323d1c8
Corrected docstring for fmx_flux_reference
vshekar Sep 11, 2023
4865dff
Merge pull request #300 from vshekar/setE-cleanup
JunAishima Sep 11, 2023
ad16669
further updates to release notes
JunAishima Sep 11, 2023
8e43bcb
remove redundant line about FMX robot mount code changes
JunAishima Sep 11, 2023
8710eab
Merge pull request #325 from NSLS-II/2023-2-amxfmx
JunAishima Sep 12, 2023
9291de4
Merge pull request #323 from JunAishima/release-notes-2023-3
JunAishima Sep 12, 2023
44ad6a4
fix ISPyB processing population error
JunAishima Sep 14, 2023
d550b92
store last 255 characters of processing call
JunAishima Sep 14, 2023
5938511
Refactored refresh dewartree view:
vshekar Sep 15, 2023
a8fef96
Set datapath during request creation to come from blconfig
vshekar Sep 15, 2023
fd7310a
Minimum working example for showing puck info
vshekar Sep 19, 2023
e0d07dd
comment out ISPyB calls to database
JunAishima Jan 11, 2022
4516e17
fix for proposal name while ISPyB is down
JunAishima Feb 7, 2022
7d1581a
restore setting visit name
JunAishima Sep 26, 2023
e58a4a3
calcLifetimeCB is only calculated if fmx
vshekar Sep 26, 2023
b6dbc58
Merge pull request #327 from vshekar/datapath-fix
JunAishima Sep 27, 2023
bac1b32
Merge pull request #331 from vshekar/2023-3-amxfmx
JunAishima Sep 27, 2023
47c98ac
Merge pull request #330 from JunAishima/re-disable-ispyb-2023-3
JunAishima Sep 27, 2023
248c920
Merge branch 'master' into 2023-3-amxfmx
JunAishima Sep 27, 2023
239fc4c
Merge pull request #332 from JunAishima/2023-3-amxfmx
vshekar Sep 28, 2023
04cd2d8
hard code ISPyB DC ID for fastDP processing
JunAishima Sep 28, 2023
8c58596
use Pillow on server to resize crystal snapshot
JunAishima Oct 2, 2023
e0f74ee
Added env variable healthcheck
vshekar Oct 2, 2023
ed862b9
Checks if user is proposal member or staff
vshekar Oct 2, 2023
0c06632
Attempting to add proposal number to puck label
vshekar Oct 2, 2023
7be5165
Merge pull request #329 from vshekar/puck-visibility
JunAishima Oct 2, 2023
151a71f
Merge pull request #333 from JunAishima/2023-3-amxfmx
JunAishima Oct 3, 2023
3571780
fix logging message - show both ratio and filename
JunAishima Oct 3, 2023
d482745
fix missing import
JunAishima Oct 3, 2023
3d7c924
Added single call to get all dewar data
vshekar Oct 13, 2023
5a17f0c
fix typo
JunAishima Oct 16, 2023
3f07c6c
Merge pull request #326 from JunAishima/2023-3-amxfmx-ispyb-processing
JunAishima Oct 16, 2023
4116872
Merge pull request #335 from JunAishima/fix-ispyb-snapshot-resize
JunAishima Oct 16, 2023
a5bd381
Merge pull request #338 from vshekar/dewar-tree-faster-refresh
JunAishima Oct 16, 2023
5e23a43
Fixed displaying puck name with proposal number
vshekar Oct 18, 2023
060b810
Added formatting to proposal id
vshekar Oct 19, 2023
f81b72d
Merge pull request #339 from vshekar/dewar-tree-puckname-fix
vshekar Oct 24, 2023
8f2a178
merge conflicts
NYSBC-Rudra Nov 2, 2023
5b486be
adding to dewar dialog
NYSBC-Rudra Nov 2, 2023
ff17926
changin dewar dialog
NYSBC-Rudra Nov 2, 2023
05b85be
changing control_main
NYSBC-Rudra Nov 7, 2023
c3a5c32
Merge branch 'master' into new_md2
NYSBC-Rudra Nov 7, 2023
12fe082
Merge pull request #1 from NYSBC-Rudra/new_md2
NYSBC-Rudra Nov 7, 2023
20ee8c0
Fixing branch
NYSBC-Rudra Nov 8, 2023
d10b8bf
Merge pull request #2 from NYSBC-Rudra/dewar_edits
NYSBC-Rudra Nov 8, 2023
1ec7ed5
Adding resolution drop down to file menu
NYSBC-Rudra Nov 8, 2023
9233638
adding gui folder to master
NYSBC-Rudra Nov 9, 2023
498ee84
changing r value edits
NYSBC-Rudra Nov 13, 2023
5e7a846
Replaced python calls with json
vshekar Nov 13, 2023
a3bde35
Removed code formatting in daq_main_common
vshekar Nov 13, 2023
d7b529b
Using send_to_server to directly send messages
vshekar Nov 14, 2023
472310b
Removed missing import
vshekar Nov 14, 2023
79071fe
Better exception handling
vshekar Nov 14, 2023
eda6414
Merge branch 'jsonize-server-comm' of https://github.com/vshekar/lsdc…
vshekar Nov 14, 2023
6a35029
making changes
NYSBC-Rudra Nov 14, 2023
7a4e958
Removed unecessary generate_server_message
vshekar Nov 14, 2023
21acc7f
Fixed bug where setTrans was passing an extra arg
vshekar Nov 15, 2023
93e8107
updating error
NYSBC-Rudra Nov 21, 2023
f6586e5
Merge pull request #3 from NYSBC-Rudra/resolutioncalc_dropdown
NYSBC-Rudra Nov 21, 2023
0bb315b
Merge branch 'master' into larger_dewar
NYSBC-Rudra Nov 21, 2023
3ad95f4
adding devices
NYSBC-Rudra Nov 21, 2023
6d644da
Merge pull request #346 from vshekar/jsonize-server-comm
vshekar Nov 21, 2023
b61960d
fixing dewar
NYSBC-Rudra Dec 4, 2023
306c6fe
Merge branch 'larger_dewar' of https://github.com/NYSBC-Rudra/lsdc in…
NYSBC-Rudra Dec 4, 2023
44c5bf2
in line with md2
NYSBC-Rudra Dec 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class RasterStatus(Enum):

GOVERNOR_TIMEOUT = 120 # seconds for a governor move

DEWAR_SECTORS = {'amx':8, 'fmx':8, 'nyx':5}
DEWAR_SECTORS = {'amx':8, 'fmx':8, 'nyx':8}
PUCKS_PER_DEWAR_SECTOR = {'amx':3, 'fmx':3, 'nyx':3}

cryostreamTempPV = {'amx': 'AMX:cs700:gasT-I', 'fmx': 'FMX:cs700:gasT-I'}
Expand Down
2 changes: 1 addition & 1 deletion daq_main_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,4 @@ def run_server():
beamline_support.pvPut(immediate_comm_pv,"\n")
comm_pv.add_callback(comm_cb)
immediate_comm_pv.add_callback(comm2_cb)
process_commands(0.5)
process_commands(0.5)
1 change: 0 additions & 1 deletion db_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -827,4 +827,3 @@ def deleteCompletedRequestsforSample(sid):
if (requestList[i]["priority"] == -1): #good to clean up completed requests after unmount
if (requestList[i]["protocol"] == "raster" or requestList[i]["protocol"] == "vector"):
deleteRequest(requestList[i]['uid'])

2 changes: 1 addition & 1 deletion gui/control_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -5408,4 +5408,4 @@ def aux_send_to_server(self, s):
logger.info("aux_send_to_server: %s" % s)
self.immediate_comm_pv.put(s)
else:
self.popupServerMessage("You don't have control")
self.popupServerMessage("You don't have control")
2 changes: 1 addition & 1 deletion gui/dewar_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -478,4 +478,4 @@ def getSelectedSample(self):
elif str(item.data(33)) == "request":
selectedSampleRequest = db_lib.getRequestByID(item.data(32))
selectedSampleID = selectedSampleRequest["sample"]
return selectedSampleID
return selectedSampleID
1 change: 1 addition & 0 deletions gui/dialog/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
from .puck_dialog import PuckDialog
from .dewar import DewarDialog
from .screen_defaults import ScreenDefaultsDialog

2 changes: 1 addition & 1 deletion gui/dialog/dewar.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def initUI(self):
for j in range(0, self.pucksPerDewarSector):
dataIndex = (i * self.pucksPerDewarSector) + j
self.allButtonList[dataIndex] = QtWidgets.QPushButton(
(str(self.data[dataIndex]))
'{}: {}'.format(str(dataIndex+1),str(self.data[dataIndex]))
)
self.allButtonList[dataIndex].clicked.connect(
functools.partial(self.on_button, str(dataIndex))
Expand Down
2 changes: 1 addition & 1 deletion gui/dialog/screen_defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,4 +271,4 @@ def checkEntryState(self, *args, **kwargs):
color = "#f6989d" # red
else:
color = "#ffffff" # white
sender.setStyleSheet("QLineEdit { background-color: %s }" % color)
sender.setStyleSheet("QLineEdit { background-color: %s }" % color)
2 changes: 1 addition & 1 deletion gui/dialog/staff_screen.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,4 +362,4 @@ def screenDefaultsCancelCB(self):
self.hide()

def screenDefaultsOKCB(self):
self.hide()
self.hide()
2 changes: 1 addition & 1 deletion gui/dialog/user_screen.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,4 +253,4 @@ def screenDefaultsCancelCB(self):
self.done(QtWidgets.QDialog.Rejected)

def screenDefaultsOKCB(self):
self.done(QtWidgets.QDialog.Accepted)
self.done(QtWidgets.QDialog.Accepted)
2 changes: 1 addition & 1 deletion ispybLib.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,4 +413,4 @@ def insertRasterResult(request,visitName):
params = mxacquisition.get_data_collection_group_params()
params['parentid'] = sessionid
params['experimenttype'] = 'OSC'
return createDataCollection(directory, filePrefix, jpegImageFilename, params, request_obj, sessionid)
return createDataCollection(directory, filePrefix, jpegImageFilename, params, request_obj, sessionid)
2 changes: 1 addition & 1 deletion md2_flyers.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,4 +266,4 @@ def update_parameters(self, omega_range, line_range, total_uturn_range, start_om
"invert_direction": invert_direction,
"use_centring_table": use_centring_table,
"use_fast_mesh_scans": use_fast_mesh_scans,
}
}
2 changes: 1 addition & 1 deletion runFastDPH5.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@
dimpleComm = getBlConfig("dimpleComm")
comm_s = f"ssh -q {dimpleNode} \"{os.environ['MXPROCESSINGSCRIPTSDIR']}dimple.sh {request_id} {numstart}\""
logger.info(f"running dimple: {comm_s}")
os.system(comm_s)
os.system(comm_s)
2 changes: 1 addition & 1 deletion setenergy_lsdc.py
Original file line number Diff line number Diff line change
Expand Up @@ -1001,4 +1001,4 @@ def beam_center_align(transSet='All'):
if transSet in ['All', 'BCU']:
yield from trans_set(transOrgBCU, trans=trans_bcu)
else:
yield from trans_set(transOrgBCU, trans=trans_bcu)
yield from trans_set(transOrgBCU, trans=trans_bcu)