Cryostream ophyd #402
Open
Cryostream ophyd #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cs700 PVPositioner for both AMX and FMX
config_params.py
Outdated
| @@ -91,7 +91,7 @@ class OnMountAvailOptions(Enum): | |||
| DEWAR_SECTORS = {'amx':8, 'fmx':8, 'nyx':8} | |||
| PUCKS_PER_DEWAR_SECTOR = {'amx':3, 'fmx':3, 'nyx':3} | |||
|
|
|||
| cryostreamTempPV = {"amx": "XF:17IDB-ES:AMX{CS:1}SAMPLE_TEMP_RBV", "fmx": "FMX:cs700:gasT-I", "nyx":"XF:19ID2:CS700:TEMP"} | |||
| cryostreamTempPV = {"amx": "XF:17ID1:CS700:TEMP", "fmx": "FMX:cs700:gasT-I", "nyx":"XF:19ID2:CS700:TEMP"} | |||
There was a problem hiding this comment.
Are these names correct? In particular the FMX one is hideous, but the other two don't follow best practices either (not your fault of course).
There was a problem hiding this comment.
The FMX one, I confirmed is incorrect. It follows the AMX, NYX formats. Fixed
| @@ -33,4 +34,18 @@ def __init__(self, *args, **kwargs): | |||
| self.cy = self.py | |||
| self.z = self.pz | |||
| self.cz = self.pz | |||
| self.omega = self.o | |||
There was a problem hiding this comment.
Is this supposed to be a removed line?
There was a problem hiding this comment.
Thanks for catching that, was a mistake
RobertSchaffer1
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cryostream ophyd device. The device will allow FMX to change the temperature via a GUI widget.
This PR only has the device, will create another PR when the GUI is components are tested