Fix Timestamp Issue #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any concerns with this @tacaswell @genematx ? It seems to properly resolve the timestamp issues (from my perspective as an end user) and we'd like to get something finalized soon ahead of our beamtime (will have a little bit of test beam next week and full 4 days starting aug 1st) |
|
This has been superseded by additions to PR #10. This PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamp issue was resolved by realizing that a detector config variable "GlobalTimestampInterval" was not being properly set, thus no global timestamps were being received. This PR provides new functions that allow for multiprocessing with global timestamps, and "old" functions that are to be used to process old data that does not have global timestamps.