Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various housekeeping updates #128

Merged
merged 15 commits into from
Jan 14, 2025
Merged

Conversation

stuartcampbell
Copy link
Collaborator

This PR includes a few things

  • general version updates for dependencies
  • fixes highlighted by uvx ruff check
  • Updates to the README.md

Copy link
Collaborator

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor confusions, but I may just need some better mongo clarity.

Using this configuration is there a network expectation? I.e. should we be running on dev machines on campus/sci, or anywhere in the world is appropriate with the right auth?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Comment on lines +37 to +38
uv pip compile requirements-dev.in --upgrade -o requirements-dev.txt
uv pip compile requirements.in --upgrade -o requirements.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a uv sync required after compile?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry no, it would just be a uv pip install -r requirements.txt - I will explicitly add that...

@maffettone maffettone merged commit 8d816b2 into NSLS2:main Jan 14, 2025
4 checks passed
@stuartcampbell stuartcampbell deleted the update-deps branch January 16, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants