Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for Y/M/D tree creation #33

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

stuartcampbell
Copy link
Collaborator

@stuartcampbell stuartcampbell commented Feb 2, 2024

I've added a field create_ymd_directory_tree which will globally default to false but is set to be true for detector (and default) directories.

The new response from the API is in an attachment in a comment below.

resolves #32

@stuartcampbell
Copy link
Collaborator Author

@danielballan
Copy link
Collaborator

Should we make this an enum, to lay track for possibly creating finer trees in some cases, like yyyy/mm/dd/hh? We have cases on the floor where directories are too large.

@nmaytan
Copy link
Collaborator

nmaytan commented Feb 2, 2024

Should we make this an enum, to lay track for possibly creating finer trees in some cases, like yyyy/mm/dd/hh? We have cases on the floor where directories are too large.

I think this is a great idea - have the enum specify the level of granularity, like create_ymd_tree: <none|hour|day|month|year>

@stuartcampbell
Copy link
Collaborator Author

stuartcampbell commented Feb 2, 2024

For clarity, are we saying that we would have one value and that would be the lowest level of granularity, e.g. if we specify month we would create assets/default/$YEAR/$MONTH/ or are we wanting a mask type thing, where if you want down to month you would specify both year and month ?

I think going with what @nmaytan suggested (i.e. <none|hour|day|month|year>) is fine and this specifies the most granular level we create, I just wanted to make sure we were all on the same page.

@danielballan danielballan merged commit 97ee6b2 into NSLS2:main Feb 6, 2024
1 check passed
@stuartcampbell stuartcampbell deleted the add-ymd-flag branch February 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to indicate if the Year/Month/Day directory tree should be created for a given directory.
3 participants