Enable log rotation for all containers using Compose file #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables automatic log rotation. Also provide a name in the compose file
|
This looks ready to me. Is this intended to still be in draft? |
|
I haven't had a chance to test this yet @dboulware |
|
Updated in #292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chooses the recommended
locallogging driver to enable automatic log rotation for all containers. Adding this configuration in the Compose file means that we don't need provisioning solutions to enforce a setting within a sensor's installation of Docker.This changes the logging driver from
json-filetolocal, so the log format is changed. Thelocaldriver defaults to preserving 100 MB of logs per container (5x20MB files). In this configuration, SCOS Sensor logs are capped at 400 MB. Modification of the Compose file can alter these settings per-sensor.(Finally!) resolves #50.