Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check input features of Model match Schema #713

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

oliverholworthy
Copy link
Member

Goals ⚽

Ensure that the model is called with features that match the Model.input_schema. This ensures that we trace the model with the correct inputs when creating a model to serve in Triton.

Implementation Details 🚧

  • Validate that all columns are processed in TabularFeatures
    • Raises exception if any columns are not used
  • Validate that the inputs match the model input_schema in the foward method of the model
    • Raises exception if these don't match

Testing Details 🔍

@rnyak rnyak modified the milestones: Merlin 23.05, Merlin 23.06 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants