Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test config to get postmerge tests running correctly #359

Merged
merged 14 commits into from
Jun 5, 2023

Conversation

oliverholworthy
Copy link
Member

Update test configuration to get postmerge tests running correctly.

@oliverholworthy oliverholworthy added this to the Merlin 23.05 milestone Jun 1, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 1, 2023
Copy link
Collaborator

@nv-alaiacano nv-alaiacano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU postmerge is still failing with a known unrelated issue - feel free to merge this one, which is a step in the right direction.

Don't forget to remove the pull_request: line from the GHA workflows fist.

@oliverholworthy
Copy link
Member Author

oliverholworthy commented Jun 1, 2023

Merged NVIDIA-Merlin/Transformers4Rec#712 which should fix the issue with the discrepancy between traced inputs and expected model inputs (resulted in KeyError in Triton). A follow-up is to add validation in Transformers4Rec to fail early in that scenario (NVIDIA-Merlin/Transformers4Rec#713)

@oliverholworthy oliverholworthy marked this pull request as ready for review June 5, 2023 19:43
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-359

@oliverholworthy oliverholworthy merged commit 5fd8277 into NVIDIA-Merlin:main Jun 5, 2023
@oliverholworthy oliverholworthy deleted the fix-postmerge branch June 5, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants