Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacheInputs propagates allocation only for matmul schedulers. #3621

Merged
merged 3 commits into from
Jan 9, 2025
Merged

cacheInputs propagates allocation only for matmul schedulers. #3621

merged 3 commits into from
Jan 9, 2025

Conversation

wujingyue
Copy link
Collaborator

Fixes #3479

@wujingyue wujingyue linked an issue Dec 19, 2024 that may be closed by this pull request
Allow allocation to be a split and different from loop. #3479
Closed
@wujingyue
Copy link
Collaborator Author

!test

@wujingyue wujingyue marked this pull request as ready for review December 19, 2024 20:57
@naoyam
Copy link
Collaborator

naoyam commented Dec 20, 2024

!test --diff

naoyam
naoyam reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just in case started the diff check

@wujingyue
Copy link
Collaborator Author

!test --diff

@wujingyue
Copy link
Collaborator Author

@naoyam diff seems good: https://dl.gitlab-master-pages.nvidia.com/pytorch/fuser-gh-mirror//nvfuser_github_ci/codegen_diff_p22279271_j132723375_1736381273526255379_codediff_e057a9ba_636a399f_custom_command_20250108_152230.html

The diff is due to the test change by this PR.

@wujingyue wujingyue requested a review from naoyam January 9, 2025 03:36
@wujingyue wujingyue merged commit 23ab1ad into main Jan 9, 2025
49 of 51 checks passed
@wujingyue wujingyue deleted the bug3479 branch January 9, 2025 04:30
@jjsjann123 jjsjann123 mentioned this pull request Jan 14, 2025
Closed
wujingyue added a commit that referenced this pull request Jan 14, 2025
@wujingyue
Revert "cacheInputs propagates allocation only for matmul schedulers. (…
9fc15cb 
…#3621)"

This reverts commit 23ab1ad.
@wujingyue wujingyue mentioned this pull request Jan 14, 2025
Merged
wujingyue added a commit that referenced this pull request Jan 14, 2025
@wujingyue
Revert "cacheInputs propagates allocation only for matmul schedulers." (
5e08e1d 
#3706)

Reverts #3621 to fix #3701
naoyam pushed a commit that referenced this pull request Jan 14, 2025
@wujingyue @naoyam
Revert "cacheInputs propagates allocation only for matmul schedulers." (
c3c2093 
#3706)

Reverts #3621 to fix #3701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zasdfgbnm zasdfgbnm zasdfgbnm approved these changes

@naoyam naoyam Awaiting requested review from naoyam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow allocation to be a split and different from loop.
3 participants
@wujingyue @naoyam @zasdfgbnm