Re-enable -Werror, with exceptions #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously disabled compiling with `-Werror` due to a bug in GCC 12.2
which erroneously causes the compile to fail. The relevant warnings in
that case were `-Wrestrict` and `-Wstringop-overflow`:
```
...
inlined from ‘nvfuser::Val* nvfuser::rules::distributeMul(nvfuser::Val*, const nvfuser::Context&)’ at /opt/pytorch/nvfuser/csrc/expr_simplifier.cpp:2414:32:
/usr/include/c++/13/bits/stl_algobase.h:437:30: warning: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 9223372036854775800 bytes at offsets 0 and 0 overlaps 9223372036854775793 bytes at offset 7 [-Wrestrict]
437 | __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
inlined from ‘std::unique_ptr<nvfuser::executor_utils::caching::VectorizedTensorInfo> nvfuser::executor_utils::{anonymous}::getVectorizedTensorValidationInfo(nvfuser::kir::Kernel*)’ at /opt/pytorch/nvfuser/csrc/runtime/executor_utils.cpp:328:72:
/usr/include/c++/13/bits/stl_construct.h:97:14: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
97 | { return ::new((void*)__location) _Tp(std::forward<_Args>(__args)...); }
```
In this PR, I'm adding `-Werror` back to the compile flags but also
adding `-Wno-error=restrict -Wno-error=stringop-overflow`. With these,
we will still get the warnings for these cases, but all other types of
warnings will give us an error. This would have caught #3001 or #3664.
Previous discussion: #3001 (comment)
|
!build |
|
Totally on board with this. Looks like CI is failing and I imagine we needed to relax quite a few more no-error in order to make CI and our build happy. |
Nah I just need to merge #3664. Then my local build succeeds at least. |
jjsjann123
approved these changes
Jan 2, 2025
|
!test |
|
!test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #3664.
We previously disabled compiling with
-Werrordue to a bug in GCC 12.2 which erroneously causes the compile to fail. The relevant warnings in that case were-Wrestrictand-Wstringop-overflow:In this PR, I'm adding
-Werrorback to the compile flags but also adding-Wno-error=restrict -Wno-error=stringop-overflow. With these, we will still get the warnings for these cases, but all other types of warnings will give us an error. This would have caught #3001 or #3664.Previous discussion: #3001 (comment)