Skip to content

Commit

Permalink
Disables pushing benchmark results for forks
Browse files Browse the repository at this point in the history
It is not easily possible to share artifacts between workflows. Instead,
we will simply not upload benchmark results from a PR from a fork. The only
edge case here would be when such a PR introduces a new performance test. In
that case, the first benchmarks for that test would only be uploaded from the
first non-fork PR.
  • Loading branch information
pranavm-nvidia committed Dec 18, 2024
1 parent de846c5 commit 5993cb9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 34 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/tripy-l0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,9 @@ jobs:
tool: 'pytest'
output-file-path: ${{ github.workspace }}/tripy/benchmark.json
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: false
auto-push: ${{ !github.event.pull_request.head.repo.fork }}
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '105%'
comment-on-alert: true
fail-on-alert: true
gh-pages-branch: benchmarks

- name: Upload benchmark result
uses: actions/upload-artifact@v4
with:
name: benchmark-results
path: ${{ github.workspace }}/tripy/benchmark.json
27 changes: 0 additions & 27 deletions .github/workflows/tripy-update-benchmark.yml

This file was deleted.

0 comments on commit 5993cb9

Please sign in to comment.