Refactor dockerfile for better caching and avoid pbss download in notebook test #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebook test Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jstjohn,
malcolmgreaves,
skothenhill-nv,
ohadmo and
trvachov
as code owners
|
/build-ci |
|
/build-ci |
dorotat-nv
approved these changes
Jan 8, 2025
|
the pbbs download was replaced with ngc in |
jstjohn
approved these changes
Jan 8, 2025
We always had both. The NGC one previously failed due to their use of the async library, but we patched that to work (hence the test). But if we want this to work on the azure runners we shouldn't test pbss |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-orders some of the Dockerfile commands to avoid re-building
tensorstorefrom source every docker build.Also removes the pbss download from
test_load_notebook.ipynbsince this can't succeed outside the nvidia VPN