Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit in the CI #255

Closed
leofang opened this issue Nov 27, 2024 · 3 comments · Fixed by #396
Closed

Run pre-commit in the CI #255

leofang opened this issue Nov 27, 2024 · 3 comments · Fixed by #396
Assignees
Labels
CI/CD CI/CD infrastructure P0 High priority - Must do!

Comments

@leofang
Copy link
Member

leofang commented Nov 27, 2024

We want the linter check to be automated

@leofang leofang added CI/CD CI/CD infrastructure P0 High priority - Must do! labels Nov 27, 2024
@shwina
Copy link
Contributor

shwina commented Jan 14, 2025

Do we want:

  1. To use pre-commit.ci? This is what CCCL uses for example.
  2. A new workflow in https://github.com/NVIDIA/cuda-python/tree/main/.github/workflows that invokes pre-commit?
  3. Something else?

@leofang
Copy link
Member Author

leofang commented Jan 14, 2025

I don't have strong opinions. Which would allow to stop building the packages if any of pre-commit checks fail? I don't think we want to even waste time building artifacts knowing the code would have to change later to meet the format & co requirements.

@leofang
Copy link
Member Author

leofang commented Jan 15, 2025

Thanks, Ashwin! FWIW I made it a required check:

Image

in action:

Image

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure P0 High priority - Must do!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants