Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch the launch argument order #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Dec 19, 2024

close #306

flip the launch args

TODO add a note to the release when the file goes into the repo (part of #237)

@ksimpson-work ksimpson-work added P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels Dec 19, 2024
@ksimpson-work ksimpson-work self-assigned this Dec 19, 2024
Copy link

copy-pr-bot bot commented Dec 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added this to the cuda.core beta 3 milestone Dec 20, 2024
@leofang
Copy link
Member

leofang commented Dec 29, 2024

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work ksimpson-work marked this pull request as ready for review January 1, 2025 22:01
@ksimpson-work ksimpson-work requested a review from leofang January 1, 2025 22:01
@leofang
Copy link
Member

leofang commented Jan 2, 2025

Let's hold off merging for now. We need to wait for Bryce's update on the kernel spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module P0 High priority - Must do!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flip kernel and config positions in launch()
2 participants