Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update out-of-date (sub)package REAME files and overhaul bindings Cython test instructions #252

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Update out-of-date (sub)package REAME files and overhaul bindings Cython test instructions #252

merged 10 commits into from
Nov 25, 2024

Conversation

vzhurba01
Copy link
Collaborator

Close #214
Close #244

@vzhurba01 vzhurba01 added enhancement Any code-related improvements cuda.bindings Everything related to the cuda.bindings module labels Nov 25, 2024
@vzhurba01 vzhurba01 self-assigned this Nov 25, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 25, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

ksimpson-work
ksimpson-work previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the title of the review doesn't quite describe everything that is going on, however everything looks good to me except on little personal-preference-nit.

README.md Outdated Show resolved Hide resolved
@vzhurba01 vzhurba01 changed the title Cython test instructions Update out-of-date (sub)package REAME files and overhaul bindings Cython test instructions Nov 25, 2024
@vzhurba01
Copy link
Collaborator Author

Merging with @ksimpson-work earlier approval. Thanks!

@vzhurba01 vzhurba01 merged commit 6adc4ee into NVIDIA:main Nov 25, 2024
rwgk
rwgk reviewed Nov 25, 2024
View reviewed changes
README.md Show resolved Hide resolved
@leofang leofang added the P0 High priority - Must do! label Nov 28, 2024
@leofang leofang mentioned this pull request Dec 2, 2024
Closed
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 6, 2025
@leofang leofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-252-to-11.8.x origin/11.8.x
cd .worktree/backport-252-to-11.8.x
git switch --create backport-252-to-11.8.x
git cherry-pick -x f919baad5e6428b5815ba60dd489b63d6928816c c6cac853f2e862c5da49e405e7ba0e43da8766bb 9f707e11482eb9650a27f6cdcd5e2fc771a09457 9b423f7103906b359ca8bb774b2c18b0e484ad5e 4602778ca303ac369ce818a652a1218c49aaa927 cf8e7b4c062d696aadf259ea28e2b369df57fa9a fde425ad1c528e2cc8b180d89d1dcb6acbb12940 800aa26279f8934d7e57434e69c069bbd2e04f10 a7bd72508bb35f4c6455a1674e2ede46e3248bf6 0fbb9e80ca9912a157a1b5260e8d75fad10a2c67

@leofang leofang mentioned this pull request Jan 6, 2025
Open
leofang added a commit to leofang/cuda-python that referenced this pull request Jan 6, 2025
@leofang
minimal treatment from NVIDIA#252
ea703c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk left review comments

@ksimpson-work ksimpson-work ksimpson-work left review comments

@leofang leofang Awaiting requested review from leofang

Assignees

@vzhurba01 vzhurba01

Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do! to-be-backported Trigger the bot to raise a backport PR upon merge
Projects
None yet
Milestone
cuda-python 12-next, 11-next
4 participants
@vzhurba01 @rwgk @leofang @ksimpson-work