Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken unit tests were fixed #217

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Broken unit tests were fixed #217

merged 1 commit into from
Dec 8, 2023

Conversation

nvvfedorov
Copy link
Collaborator

A few unit tests could be run on a machine with specific hardware. The reason for the failure is dependency on hardware.

I used hooking technology to add an abstraction layer between dcgm-exporter and the dcgm library. When creating a unit test, we can use mocks to emulate a dcgm behavior during various scenarios.

Signed-off-by: Vadym Fedorov <vfedorov@nvidia.com>
@nvvfedorov nvvfedorov self-assigned this Dec 8, 2023
@nvvfedorov nvvfedorov requested review from glowkey and dbeer December 8, 2023 16:38
@glowkey glowkey merged commit 512b16e into main Dec 8, 2023
1 check passed
@glowkey glowkey deleted the fix-broken-tests branch December 8, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants