Rename default PCIe metrics for better readability #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koshieguchi
force-pushed
the
update-default-pcie-metrics-names
branch
from
96f2e3a to
3cf0196
Compare
Signed-off-by: Koshi Eguchi <koshieguegu@gmail.com>
koshieguchi
force-pushed
the
update-default-pcie-metrics-names
branch
from
3cf0196 to
99a774b
Compare
|
@glowkey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #354
Description
This PR updates the default PCIe metric from
DCGM_FI_DEV_PCIE_{TX,RX}_THROUGHPUTtoDCGM_FI_PROF_PCIE_{TX,RX}_BYTESin./etcfiles to align with the DCGM Documentation (Version 3.3).Background
According to the DCGM Documentation,
DCGM_FI_DEV_PCIE_{TX,RX}_THROUGHPUTis deprecated and should be replaced withDCGM_FI_PROF_PCIE_{TX,RX}_BYTES. This change resolves issues reported in Issue #167.Changes Made
DCGM_FI_DEV_PCIE_{TX,RX}_THROUGHPUTwithDCGM_FI_PROF_PCIE_{TX,RX}_BYTESin./etc/default-counters.csv.References