Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'secuity' to 'security' #374

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

remram44
Copy link
Contributor

No description provided.

@nvvfedorov
Copy link
Collaborator

@remram44 , Please sign your commit

@remram44
Copy link
Contributor Author

Bump

@glowkey
Copy link
Collaborator

glowkey commented Oct 23, 2024

The commit needs to be signed (git commit -S) before it can be merged.

@remram44
Copy link
Contributor Author

It is signed

@glowkey
Copy link
Collaborator

glowkey commented Oct 24, 2024

Check out this link: https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification You'll notice that this commit does not have the "Verified" tag.

@remram44
Copy link
Contributor Author

Your contributing guide says I need to "sign-off" commits, not GPG-sign them. Are you sure you are not confusing those?

Signed-off-by: Remi Rampin <remi@rampin.org>
@glowkey glowkey merged commit e9bd7d2 into NVIDIA:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants