Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reconciliation failure monitor. #555

Closed
wants to merge 1 commit into from
Closed

Fix reconciliation failure monitor. #555

wants to merge 1 commit into from

Commits on Jul 20, 2023

  1. Fix reconciliation failure monitor. 

    Previsouly the expr was trying to include the timeframe check. The problem with this is that the last_success timestamp is only updated when the Reconcile method is triggered. It is possible to have no update or triggering of the Reconcile method for over an hour (no changes to ClusterPolicy, DaemonSets, or GPU Nodes). When this happens and a new GPU Node is added, an alert will immediately fire because the last_success timestamp hasn't updated in over an hour and the reconciliation status will change to "0"/"NotReady" as the new GPU is being proessed.

Resolve this by using the timeframe tracking of Alertmananger and only watching for reconcilitation_status not being Ready (1).
    @montaguethomas
    montaguethomas authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c7ef002 View commit details
    Browse the repository at this point in the history