changes to allow custom labels for ServiceMonitor #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csauoss
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
|
changes look good, @csauoss can you rebase please. |
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
8e8e5ec
to
deb5368
Compare
@shivamerla Thanks for taking a look. pulled in changes from main and did the rebase. |
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
deb5368
to
9a049dc
Compare
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
9a049dc
to
1a0f052
Compare
Signed-off-by: Saurabh Choudhary <csauoss@gmail.com>
csauoss
force-pushed
the
servicemonitor-custom-labels
branch
from
1a0f052
to
a2c5c59
Compare
|
@shivamerla can you please review it again when you get a chance? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses issue 710 to allow passing custom labels for gpu-operator's ServiceMonitor.