add ngc signing job for auto signing #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
approved these changes
Jul 16, 2024
Signed-off-by: shiva kumar <shivaku@nvidia.com>
shivakunv
force-pushed
the
ngc_signing_job
branch
from
6e0ba05
to
f66cab1
Compare
cdesiniotis
reviewed
Jul 16, 2024
Comment on lines
+189
to
+202
| sign:ngc: | ||
| extends: | ||
| - .sign:ngc | ||
| parallel: | ||
| matrix: | ||
| - SIGN_JOB_NAME: [""] | ||
| DIST: ["CI_COMMIT_TAG", "ubi8"] | ||
| rules: | ||
| - if: '$DIST == "CI_COMMIT_TAG"' | ||
| variables: | ||
| IMAGE_TAG: "${SIGN_JOB_NAME}${CI_COMMIT_TAG}" | ||
| - when: always | ||
| variables: | ||
| IMAGE_TAG: "${SIGN_JOB_NAME}${CI_COMMIT_TAG}-${DIST}" |
There was a problem hiding this comment.
@shivakunv I have some comments:
- Specifying
when: alwaysis incorrect since now the sign job is always added to every pipeline (not just pipelines triggered from tag events). - Can we simplify this a bit since
SIGN_JOB_NAMEis never used?
What about my below suggestion?
sign:ngc:
extends:
- .sign:ngc
variables:
IMAGE_TAG: "${CI_COMMIT_TAG}-${DIST}"
parallel:
matrix:
- DIST: ["SHORT_TAG", "ubi8"]
rules:
- if: $CI_COMMIT_TAG && $DIST == "SHORT_TAG"
variables:
IMAGE_TAG: "${CI_COMMIT_TAG}"
There was a problem hiding this comment.
@cdesiniotis addressed in :
#35
thanks @elezar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.