Skip to content

Commit

Permalink
Add helm linting
Browse files Browse the repository at this point in the history
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
  • Loading branch information
ArangoGutierrez committed Aug 2, 2024
1 parent 9513df0 commit 04e16f9
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 4 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/helm.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Lint Helm Charts

on:
pull_request:
types:
- opened
- synchronize
branches:
- main
- release-*
push:
branches:
- main
- release-*

jobs:
lint-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
name: Checkout code
- name: Set up Helm
uses: azure/setup-helm@v4.2.0
with:
version: v3.14.4
- name: Lint Helm Charts
run: helm lint helm/*
2 changes: 1 addition & 1 deletion .github/workflows/image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}
- name: Build image
env:
IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/nim-operator
IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/k8s-nim-operator
VERSION: ${COMMIT_SHORT_SHA}
run: |
echo "${VERSION}"
Expand Down
2 changes: 1 addition & 1 deletion deployments/container/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ MKDIR ?= mkdir
include $(CURDIR)/versions.mk

ifeq ($(IMAGE_NAME),)
IMAGE_NAME := $(REGISTRY)/$(DRIVER_NAME)
IMAGE_NAME := $(REGISTRY)/$(MODULE_NAME)
endif

IMAGE_VERSION := $(VERSION)
Expand Down
4 changes: 2 additions & 2 deletions versions.mk
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
# To re-generate a bundle for another specific version without changing the standard setup, you can:
# - use the VERSION as arg of the bundle target (e.g make build-bundle-image VERSION=0.0.2)
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2)
DRIVER_NAME := nim-operator
MODULE := github.com/NVIDIA/$(DRIVER_NAME)
MODULE_NAME := k8s-nim-operator
MODULE := github.com/NVIDIA/$(MODULE_NAME)

REGISTRY ?= nvcr.io/nvidia

Expand Down

0 comments on commit 04e16f9

Please sign in to comment.