Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Modify NeMoDataStore #286

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Draft: Modify NeMoDataStore #286

wants to merge 4 commits into from
+872 −182

Conversation

shengnuo
Copy link

@shengnuo shengnuo commented Jan 16, 2025 •
edited
Loading

New API for supporting DataStore V2

Sample CR can be found at config/samples/apps_v1alpha1_nimdatastorev2.yaml

pre-requisite components:

  • Minio
  • Postgres

Secrets as specified in .spec.dataStoreParams that need to be created before deploying DataStore microservice

  • datastoreConfigSecret
  • datastoreInitSecret
  • datastoreInlineConfigSecret
  • extDBSetting.databaseSecret
  • giteaAdminSecret
  • lfsJwtSecret
  • objectStoreSetting.objectStoreSecret

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shengnuo shengnuo changed the title Support DataStore V2 Draft: Support DataStore V2 Jan 16, 2025
slu2011
slu2011 previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@slu2011 slu2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shengnuo shengnuo force-pushed the dsv2 branch 2 times, most recently from 55ee5ce to d16ae69 Compare January 18, 2025 23:18
shil and others added 2 commits January 18, 2025 18:20
@shengnuo
chore: temp work to support datastore v2
233efe6 
Signed-off-by: Sheng Lin <shelin@nvidia.com>
@shengnuo
Support DataStore V2
020b320 
Signed-off-by: Sheng Lin <shelin@nvidia.com>
@shengnuo shengnuo force-pushed the dsv2 branch 2 times, most recently from 2635757 to 735cdd7 Compare January 18, 2025 23:42
@shengnuo
Deprecate DataStore v1
c46cd53 
Signed-off-by: Sheng Lin <shelin@nvidia.com>
@shengnuo shengnuo force-pushed the dsv2 branch 2 times, most recently from 3f314aa to 37ed08c Compare January 22, 2025 23:04
@shengnuo
Add objectStoreSetting and extDBSetting to dataStoreParams
adfeb38 
Signed-off-by: Sheng Lin <shelin@nvidia.com>
@shengnuo shengnuo changed the title Draft: Support DataStore V2 Draft: Modify NeMoDataStore Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamerla shivamerla shivamerla left review comments

@slu2011 slu2011 slu2011 left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shengnuo @slu2011 @shivamerla