Bump project version to v0.6.0 #40
Conversation
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
| * Wed Feb 28 2024 NVIDIA CORPORATION <cudatools@nvidia.com> 0.6.0-1 | ||
| - Update to latest CUDA base image 12.3.2 | ||
| - Migrate to using github.com/NVIDIA/go-nvlib | ||
| - Bump Golang version to 1.20.5 |
There was a problem hiding this comment.
Can we bump golang to 1.21 as go 1.20 is close to EOL?
There was a problem hiding this comment.
It may not be possible at the moment due to:
https://gitlab.com/nvidia/cloud-native/mig-parted/-/merge_requests/133#note_1467441468
There was a problem hiding this comment.
I believe the glibc issue (which is the reason why we never updated go past 1.20.5) can be avoided by installing go in the target base image. For example: https://github.com/NVIDIA/k8s-device-plugin/blob/main/deployments/container/Dockerfile.ubi8#L19-L37
This would require changes to our Dockerfiles though. Do we want to make this change and the Go version bump to be included in the 0.6.0 release?
There was a problem hiding this comment.
I think we could make this change ahead of the next planned gpu operator release. Not an immediate requirement imo
There was a problem hiding this comment.
It appears the Dockerfile changes for mig-manager were made already in this commit: 86bb919. However, the Dockerfiles used to build the mig-parted deb / rpm packages were not updated with this change, meaning that updating Go may cause our packages to no longer work on systems with older glibc versions.
@elezar do we want to duplicate the Dockerfile changes here as well? https://github.com/NVIDIA/mig-parted/tree/main/deployments/systemd/packages
I will proceed with the 0.6.0 release. We can look to update Go in a follow-up.
No longer needed since this change: 6d18ec1 |
No description provided.