Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix for dlwp_healpix dataloader not subsetting channels correctly #683

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

daviddpruitt
Copy link
Collaborator

Modulus Pull Request

Description

Fixes a bug where the dlwp_healpix dataloader uses a prebuilt dataset with more channels than used by the model. This fix adds channel selection so only the necessary channels are loaded.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Copy link
Contributor

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnabian
Copy link
Collaborator

mnabian commented Oct 25, 2024

@daviddpruitt is this ready to be merged?

@daviddpruitt
Copy link
Collaborator Author

@daviddpruitt is this ready to be merged?

@mnabian Should be good to go.

@daviddpruitt
Copy link
Collaborator Author

/blossom-ci

Copy link
Collaborator

@akshaysubr akshaysubr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and fixes the stated issue.

@akshaysubr akshaysubr merged commit f46e25f into NVIDIA:main Oct 29, 2024
1 check passed
@daviddpruitt daviddpruitt deleted the dlwp_healpix_dataloader_fix branch November 5, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants