[fix] Fix for failing healpix dataloader test #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pting cuda install
|
@daviddpruitt who should review this PR? |
Either @akshaysubr or @NickGeneva would be my pick |
…IA#702) Co-authored-by: David Pruitt <dpruitt@nvidia.com>
--------- Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com> Co-authored-by: Kaustubh <ktangsali@nvidia.com>
ktangsali
approved these changes
Nov 19, 2024
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
ktangsali
added a commit
that referenced
this pull request
Nov 27, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install * Update the conf paths in docs (#712) * Fix for dlwp_healpix dataloader not including coupled variables (#702) Co-authored-by: David Pruitt <dpruitt@nvidia.com> * Adding DoMINO example to Modulus (#709) --------- Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com> Co-authored-by: Kaustubh <ktangsali@nvidia.com> --------- Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com> Co-authored-by: ivanauyeung <106317256+ivanauyeung@users.noreply.github.com> Co-authored-by: RishikeshRanade <65631160+RishikeshRanade@users.noreply.github.com> Co-authored-by: Kaustubh <ktangsali@nvidia.com>
ktangsali
added a commit
that referenced
this pull request
Nov 27, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install * Update the conf paths in docs (#712) * Fix for dlwp_healpix dataloader not including coupled variables (#702) Co-authored-by: David Pruitt <dpruitt@nvidia.com> * Adding DoMINO example to Modulus (#709) --------- Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com> Co-authored-by: Kaustubh <ktangsali@nvidia.com> --------- Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com> Co-authored-by: ivanauyeung <106317256+ivanauyeung@users.noreply.github.com> Co-authored-by: RishikeshRanade <65631160+RishikeshRanade@users.noreply.github.com> Co-authored-by: Kaustubh <ktangsali@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
Fixes a bug where the healpix dataloader would fail sometimes.
Test was refactored to prevent failure and catch additional errors. Coupled dataloader was updated to remove some warnings.
Checklist
Dependencies