Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for dlwp_healpix dataloader not including coupled variables #702

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

ivanauyeung
Copy link
Contributor

Modulus Pull Request

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@yairchn yairchn self-requested a review November 15, 2024 13:15
Copy link
Contributor

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested it many times with a local brach

@yairchn
Copy link
Contributor

yairchn commented Nov 18, 2024

/blossom-ci

1 similar comment
@daviddpruitt
Copy link
Collaborator

/blossom-ci

@daviddpruitt daviddpruitt merged commit bedf90b into NVIDIA:main Nov 18, 2024
1 check passed
ktangsali added a commit that referenced this pull request Nov 19, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install

* Update the conf paths in docs (#712)

* Fix for dlwp_healpix dataloader not including coupled variables (#702)

Co-authored-by: David Pruitt <dpruitt@nvidia.com>

* Adding DoMINO example to Modulus (#709)



---------

Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com>
Co-authored-by: Kaustubh <ktangsali@nvidia.com>

---------

Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com>
Co-authored-by: ivanauyeung <106317256+ivanauyeung@users.noreply.github.com>
Co-authored-by: RishikeshRanade <65631160+RishikeshRanade@users.noreply.github.com>
Co-authored-by: Kaustubh <ktangsali@nvidia.com>
ktangsali added a commit that referenced this pull request Nov 27, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install

* Update the conf paths in docs (#712)

* Fix for dlwp_healpix dataloader not including coupled variables (#702)

Co-authored-by: David Pruitt <dpruitt@nvidia.com>

* Adding DoMINO example to Modulus (#709)



---------

Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com>
Co-authored-by: Kaustubh <ktangsali@nvidia.com>

---------

Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com>
Co-authored-by: ivanauyeung <106317256+ivanauyeung@users.noreply.github.com>
Co-authored-by: RishikeshRanade <65631160+RishikeshRanade@users.noreply.github.com>
Co-authored-by: Kaustubh <ktangsali@nvidia.com>
ktangsali added a commit that referenced this pull request Nov 27, 2024
* Move cuda padding routines to healpix.py, check for cuda before attempting cuda install

* Update the conf paths in docs (#712)

* Fix for dlwp_healpix dataloader not including coupled variables (#702)

Co-authored-by: David Pruitt <dpruitt@nvidia.com>

* Adding DoMINO example to Modulus (#709)



---------

Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com>
Co-authored-by: Kaustubh <ktangsali@nvidia.com>

---------

Co-authored-by: Kaustubh Tangsali <71059996+ktangsali@users.noreply.github.com>
Co-authored-by: ivanauyeung <106317256+ivanauyeung@users.noreply.github.com>
Co-authored-by: RishikeshRanade <65631160+RishikeshRanade@users.noreply.github.com>
Co-authored-by: Kaustubh <ktangsali@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants