Add scaling for HPX dataloaders, code cleanup #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddpruitt
force-pushed
the
hpx_const_scaling
branch
from
781705f to
12c13da
Compare
|
/blossom-ci |
|
/blossom-ci |
akshaysubr
approved these changes
Dec 3, 2024
pzharrington
approved these changes
Dec 3, 2024
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modulus Pull Request
Description
This adds scaling values for constant values in Healpix datasets.
If scaling values are given they will also be required for constant fields.
Removed duplicate code from coupled healpix dataloader to eliminate differing behaviour.
Closes #716
Checklist
Dependencies