Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy version upper bound #729

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

ktangsali
Copy link
Collaborator

Modulus Pull Request

Description

Removes the numpy version upper bound. Tested these changes with the PyTorch 24.11 container

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@ktangsali
Copy link
Collaborator Author

/blossom-ci

@ktangsali
Copy link
Collaborator Author

/blossom-ci

@NickGeneva
Copy link
Collaborator

Any chance we can also check on the note that Peter found about needing the extra index-url for DALI builds?

@NickGeneva
Copy link
Collaborator

/blossom-ci

Copy link
Collaborator

@peterdsharpe peterdsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good to me, contingent on CI pass!

@NickGeneva
Copy link
Collaborator

/blossom-ci

1 similar comment
@NickGeneva
Copy link
Collaborator

/blossom-ci

@NickGeneva NickGeneva merged commit c933538 into NVIDIA:main Dec 12, 2024
1 check passed
@ktangsali ktangsali deleted the remove-numpy-pin branch January 2, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants