Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Commit

Permalink
Require that TOOLKIT_VERSION be set externally
Browse files Browse the repository at this point in the history
This change removes the default value for TOOLKIT_VERSION and checks that this
is set. A warning is also issued if the package TAGS do not match.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
  • Loading branch information
elezar committed Nov 24, 2021
1 parent 4a1492f commit a25921b
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,18 @@ LIB_NAME := nvidia-docker2
LIB_VERSION := 2.8.0
LIB_TAG ?= rc.1

TOOLKIT_VERSION ?= 1.7.0
TOOLKIT_TAG ?= $(LIB_TAG)
# Define the nvidia-container-toolkit version on which the nvidia-docker2
# package depends. It is recommended that the TOOLKIT_TAG and the LIB_TAG match.
TOOLKIT_VERSION ?= # Set by CI
TOOLKIT_TAG ?= # Set by CI

ifeq ($(strip $(TOOLKIT_VERSION)),)
$(error TOOLKIT_VERSION must be specified)
endif

ifneq ($(TOOLKIT_TAG),$(LIB_TAG))
$(warning TOOLKIT_TAG=$(TOOLKIT_TAG) and LIB_TAG=$(LIB_TAG) do not match)
endif

# By default run all native docker-based targets
docker-native:
Expand Down

0 comments on commit a25921b

Please sign in to comment.