Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hard-coded collision value will cause small deformable bodies to be unstable/inaccurate. #329

Open
mmichelis opened this issue Oct 16, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mmichelis
Copy link

Bug Description

In warp/sim/integrator_euler.py line 306 there are hard-coded collision checks between triangles that are less than 0.01 apart. When loading a soft deformable mesh that is on millimeter scale, these collision checks will come into play and cause artificial damping in best case, and divergence in worst case scenarios. The symplectic integrator will no longer be energy-conserving when this self-collision check is done between each particle in the soft mesh.

System Information

No response

@mmichelis mmichelis added the bug Something isn't working label Oct 16, 2024
@AnkaChan
Copy link
Contributor

Hi @mmichelis, thank you for bringing this up. I will look into it. We can make this value an adjustable parameter, such as soft_contact_radius within Model.

@mmichelis
Copy link
Author

Excellent, thanks!

@shi-eric
Copy link
Contributor

Let's leave the issue open until the fix is in so we can keep an eye on it.

@shi-eric shi-eric reopened this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants