Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial prometheus metrics support #42

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

aakselrod-nydig
Copy link
Contributor

This PR enables initial support of Prometheus monitoring, including basic GRPC client and server support, as specified by #15. Notably, adding custom metrics is out of scope for this PR and will be done as part of a PR addressing #23.

cmd/lnmuxd/run.go Show resolved Hide resolved
cmd/lnmuxd/run.go Show resolved Hide resolved
cmd/lnmuxd/run.go Outdated Show resolved Hide resolved
cmd/lnmuxd/run.go Show resolved Hide resolved
Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joostjager joostjager mentioned this pull request Jul 27, 2022
@aakselrod-nydig aakselrod-nydig merged commit 9378f50 into NYDIG-OSS:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants