stateless invoices #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
stateless
branch
9 times, most recently
from
9c56e42
to
d17b9bb
Compare
qustavo
reviewed
Jun 29, 2022
For stateless invoices, there is no option anymore to store this value per invoice.
qustavo
reviewed
Jun 29, 2022
aakselrod-nydig
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
This looks great and simplifies the code a lot! I did leave a couple of comments about potentially handling a set of HTLCs that overpays an invoice, which could be especially useful in the case of donations or overpayments for the sake of reliable routing. If you want to make a TODO, I would like to implement a test for this condition and the handling of it as a first issue for me?
qustavo
reviewed
Jul 1, 2022
joostjager
force-pushed
the
stateless
branch
2 times, most recently
from
6e42206
to
8150785
Compare
qustavo
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts lnmux to always use stateless invoices. This means that nothing needs to be stored on disk when an invoice is generated.
As a result of this, the number of invoice (sub)states in the database is reduced as well. Only incoming payments for which settlement is requested are stored on disk.