Skip to content

Commit

Permalink
Merge branch 'fadesign-845_fix-open-in-reader-buttons-on-topic-pages'…
Browse files Browse the repository at this point in the history 
… into develop
  • Loading branch information
@da70
da70 committed Mar 15, 2022
2 parents cd6a94f + 5f3f824 commit 0d66646
Show file tree
Hide file tree
Showing 31 changed files with 1,939 additions and 278 deletions.
10 changes: 9 additions & 1 deletion sitegen/templates/topic-page/epub.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,15 @@ <h3 class="title is-5">
<div class="meta">{{.Authors}}; {{.Publisher}}</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>
{{$hrefForReaderButton := hrefForReaderButton .Publisher .ISBN}}
{{if ne $hrefForReaderButton ""}}
<a
href="{{$hrefForReaderButton}}"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>
{{end}}
</div>
</nav>
</div>
Expand Down
66 changes: 58 additions & 8 deletions sitegen/testdata/golden/topic-pages/no-google-analytics/00/00/00/00/0000000062.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,15 @@ <h3 class="title is-5">
<div class="meta">Stanley A. Renshon; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814776636/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -120,7 +128,15 @@ <h3 class="title is-5">
<div class="meta">Keith Beattie; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814709108/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -141,7 +157,15 @@ <h3 class="title is-5">
<div class="meta">Sonia Livingstone and Julian Sefton-Green; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9781479863570/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -162,7 +186,15 @@ <h3 class="title is-5">
<div class="meta">Pearl M. Oliner; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814762622/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -183,7 +215,15 @@ <h3 class="title is-5">
<div class="meta">Peter N. Stearns; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814771037/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -204,7 +244,8 @@ <h3 class="title is-5">
<div class="meta">Steven Chung; University of Minnesota Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -225,7 +266,15 @@ <h3 class="title is-5">
<div class="meta">Marshall W. Alcorn, Jr.; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814707517/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -246,7 +295,8 @@ <h3 class="title is-5">
<div class="meta">Angelina E. Castagno; University of Minnesota Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand Down
103 changes: 85 additions & 18 deletions sitegen/testdata/golden/topic-pages/no-google-analytics/00/00/00/08/0000000826.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,15 @@ <h3 class="title is-5">
<div class="meta">Ryuzo Sato; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814788707/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -120,7 +128,8 @@ <h3 class="title is-5">
<div class="meta">Alexander, Buzz; The University of Michigan Press and The University of Michigan Library</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -141,7 +150,8 @@ <h3 class="title is-5">
<div class="meta">Antonio T. Tiongson Jr.; University of Minnesota Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -162,7 +172,8 @@ <h3 class="title is-5">
<div class="meta">Amy Koritz and George J. Sanchez; University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -183,7 +194,8 @@ <h3 class="title is-5">
<div class="meta">Stein, Kevin; The University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -204,7 +216,8 @@ <h3 class="title is-5">
<div class="meta">Schur, Richard L.; The University of Michigan Press and The University of Michigan Library</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -225,7 +238,15 @@ <h3 class="title is-5">
<div class="meta">Ian Shapiro; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814739617/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -246,7 +267,8 @@ <h3 class="title is-5">
<div class="meta">Elizabeth Carolyn Miller; University of Michigan Press and University of Michigan Library</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -267,7 +289,15 @@ <h3 class="title is-5">
<div class="meta">Seth Forman; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814728901/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -288,7 +318,15 @@ <h3 class="title is-5">
<div class="meta">Mark Hertzog; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814773215/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -309,7 +347,8 @@ <h3 class="title is-5">
<div class="meta">Eisner, Caroline; Vicinus, Martha; University of Michigan Press and University of Michigan Library</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -330,7 +369,8 @@ <h3 class="title is-5">
<div class="meta">Klein, Julie Thompson; University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -351,7 +391,8 @@ <h3 class="title is-5">
<div class="meta">Darling-Wolf, Fabienne; University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -372,7 +413,8 @@ <h3 class="title is-5">
<div class="meta">Lee, Chin-Chuan; University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand All @@ -393,7 +435,15 @@ <h3 class="title is-5">
<div class="meta">Henry Jenkins et al; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9781479829712/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -414,7 +464,15 @@ <h3 class="title is-5">
<div class="meta">Ronald Suresh Roberts; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814769461/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -435,7 +493,15 @@ <h3 class="title is-5">
<div class="meta">Thomas Cushman; New York University Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


<a
href="https://opensquare.nyupress.org/books/9780814723708/read/"
class="button level-item is-primary is-outlined is-small"
target="_blank">
Read book
</a>

</div>
</nav>
</div>
Expand All @@ -456,7 +522,8 @@ <h3 class="title is-5">
<div class="meta">Turrow, Joseph; Tsui, Lokman; University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand Down
3 changes: 2 additions & 1 deletion sitegen/testdata/golden/topic-pages/no-google-analytics/00/00/00/08/0000000885.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ <h3 class="title is-5">
<div class="meta">Amy Koritz and George J. Sanchez; University of Michigan Press</div>
<nav class="level is-mobile">
<div class="level-right">
<a class="button level-item is-primary is-outlined is-small">Open in Reader</a>


</div>
</nav>
</div>
Expand Down
Loading

0 comments on commit 0d66646

Please sign in to comment.