When building for Windows - The "path" argument must be of type string.

[ryanlovett-au]

What were you trying to do?

Doing a php artisan native:build win x64 generates a JavaScript error when executing electron-builder.js

What happened?

This error is generated:

How to reproduce the bug

I tracked the error down to this line in electron-builder.js

Commenting out the minify command, and re-building resulted in no errors being generated.

I then manually reverted this change from 0.6.3 -> 0.6.4 and it also built without issue.

Package Versions

0.6.4 & 0.6.5

PHP Version

8.3.8

Laravel Version

10.48

Node Version

21.7

Which operating systems have you seen this occur on?

Windows

OS version

Win10

Notes

No response

[simonhamp]

Hmm... I'm not sure it is the minify command that's the problem... I think that may be a red herring due to how the CLI output on error is handling the different try-catch blocks.

The error in your first screenshot references vendor\nativephp\electron\resources\js\php.js somewhere around line 55. The throw that happens there is to do with unzipping the relevant php binary from the nativephp/php-bin package.

My guess is that it can't find the file when trying to run the unzip but on a later pass, it was in the right place. This suggest some variability in the behaviour of composer install when running the build.

I will need to do some further testing to work out why it's not in the right place at that point in time - it should be 🤷🏼

[simonhamp]

Related to #336 ?

[simonhamp]

Please update to the latest versions of NativePHP's dependencies and try again