Skip to content

Commit

Permalink
fix: pass propName as const to GetChildMetadataForPackage
Browse files Browse the repository at this point in the history
  • Loading branch information
ammarahm-ed committed Oct 7, 2024
1 parent 10bd6a2 commit 98970ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/MetadataNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1802,7 +1802,7 @@ MetadataNode* MetadataNode::GetNodeFromHandle(const Local<Object>& value) {
return node;
}

MetadataEntry MetadataNode::GetChildMetadataForPackage(MetadataNode *node, std::string propName) {
MetadataEntry MetadataNode::GetChildMetadataForPackage(MetadataNode *node, const std::string &propName) {
assert(node->m_treeNode->children != nullptr);

MetadataEntry child(nullptr, NodeType::Class);
Expand Down
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/MetadataNode.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class MetadataNode {

static MetadataTreeNode* GetOrCreateTreeNodeByName(const std::string& className);

static MetadataEntry GetChildMetadataForPackage(MetadataNode *node, std::string propName);
static MetadataEntry GetChildMetadataForPackage(MetadataNode *node, const std::string &propName);

static MetadataNode* GetInstanceMetadata(v8::Isolate* isolate, const v8::Local<v8::Object>& value);

Expand Down

0 comments on commit 98970ae

Please sign in to comment.