From 98970ae49ae2eed8536e723bde4520ff6921d142 Mon Sep 17 00:00:00 2001 From: Ammar Ahmed Date: Tue, 8 Oct 2024 01:42:36 +0500 Subject: [PATCH] fix: pass propName as const to GetChildMetadataForPackage --- test-app/runtime/src/main/cpp/MetadataNode.cpp | 2 +- test-app/runtime/src/main/cpp/MetadataNode.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test-app/runtime/src/main/cpp/MetadataNode.cpp b/test-app/runtime/src/main/cpp/MetadataNode.cpp index 011255512..e224f6601 100644 --- a/test-app/runtime/src/main/cpp/MetadataNode.cpp +++ b/test-app/runtime/src/main/cpp/MetadataNode.cpp @@ -1802,7 +1802,7 @@ MetadataNode* MetadataNode::GetNodeFromHandle(const Local& value) { return node; } -MetadataEntry MetadataNode::GetChildMetadataForPackage(MetadataNode *node, std::string propName) { +MetadataEntry MetadataNode::GetChildMetadataForPackage(MetadataNode *node, const std::string &propName) { assert(node->m_treeNode->children != nullptr); MetadataEntry child(nullptr, NodeType::Class); diff --git a/test-app/runtime/src/main/cpp/MetadataNode.h b/test-app/runtime/src/main/cpp/MetadataNode.h index e8a7565df..dbdcd606c 100644 --- a/test-app/runtime/src/main/cpp/MetadataNode.h +++ b/test-app/runtime/src/main/cpp/MetadataNode.h @@ -121,7 +121,7 @@ class MetadataNode { static MetadataTreeNode* GetOrCreateTreeNodeByName(const std::string& className); - static MetadataEntry GetChildMetadataForPackage(MetadataNode *node, std::string propName); + static MetadataEntry GetChildMetadataForPackage(MetadataNode *node, const std::string &propName); static MetadataNode* GetInstanceMetadata(v8::Isolate* isolate, const v8::Local& value);