Temporarily add clang dependency to natron-build-deps-qt5 package. #935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Updates the natron-build-deps-qt5 MinGW package to have a dependency on the clang package. This is needed because a recent change to the MSYS shiboken2 package (msys2/MINGW-packages@c210274) broke the Windows Natron build. I believe the underlying issue stems from the MSYS shiboken2 not being able to find g++ because it tries to look for it in a hard-coded path that is only valid when that package was built. Unfortunately fixing that issue might not be straight forward, so for now I'm adding back the dependency on clang so that Natron is at least able to build again on Windows.
Have you tested your changes (if applicable)? If so, how?
Yes. I've rebuilt the natron-build-deps-qt5 package locally and used it to build Natron. I've also verified that "Build pacman repo" action is able to build the package as well (https://github.com/acolwell/Natron/actions/runs/7341376846).
Futher details of this pull request
The Windows installer and Test build actions will not start working again until the "Natron MinGW pacman repository" release (https://github.com/NatronGitHub/Natron/releases/tag/windows-mingw-package-repo) is updated with the new packages. My plan is to land this change and then update the release with a new zip file generated from the "Build pacman repo" action. Once that is done, the Windows installer and Test actions should start working again.