Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenImageIO to 2.5.13.1 and OpenEXR to 3.2.4 #983

Merged

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

  • Fixes Build Installer action to fail the build when the Natron-Tests fail to match the 2.5.0. The old code printed a failure message, but didn't cause the build step to actually fail.
  • Updated OpenImageIO package to the latest stable version (2.5.13.1). The PKGBUILD file was reorganized a bit to more closely match the current upstream version in the MSYS2 repository. I also removed old patches that were no longer used or needed. This should make future updates easier and the diffs for those updates smaller.
  • Updated OpenEXR package to its latest stable version (3.2.4). This was needed because the update of OpenImageIO alone was causing the BayMax testcase to fail. The EXR decoding had weird artifacts. That particular test uses a dwa compressed file and I suspect the recent fixes in OpenEXR related to dwa compression are needed for the new version of OpenImageIO to work properly.

Have you tested your changes (if applicable)? If so, how?

Yes. The Build Installer action fix was verified by this build where only OpenImageIO was updated. You can see the build step for that failed and that the BayMax test caused the failure. This build includes the OpenEXR update and as you can see the build completes successfully and the BayMax test no longer fails.

acolwell added 3 commits July 19, 2024 09:39
Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
@acolwell acolwell merged commit 73e7dd8 into NatronGitHub:RB-2.6 Jul 20, 2024
4 checks passed
@acolwell acolwell deleted the update_to_latest_openimageio_stable branch July 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants