Fix issue with this plugin and 2.10 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this we don't define an "authenticate" method which is then expected in 2.10+ under certain scenarios. This is a temp patch as we should reimplement this library to use this new pathway but for the moment, we haven't had the time.
|
Confirmed working in 2.9 staging environment. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "solves" an issue with running this plugin on 2.10 ckan where a method plugins implementing IAuthenticator was expected but wasn't provided by us (specifically
authenticatewhich was added in 2.10.0). By inheriting the IAuthenticator base version we solve this problem for now, in that the plugin should work but it's still implemented in an old fashioned way and we should move to a more modern implementation.The key change is here: 364cd80, the other changes in this PR relate to detailing the CKAN 2.9 and 2.10 testing information in the readme.
I will test this on our staging site before merging, but both 2.9 and 2.10 tests pass with this change.
Closes #131