Remove image magick from jpg conversion code #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a tiff which when converted just causes a seg fault from Image Magick due to an assertion error. Not sure why this happens so let's just remove Image Magick from the convert function and in turn just remove it completely from the project as this was the only place it was being used. Shame as it was faster than pillow, hence why it was there, but you can't catch a seg fault and without knowing why the image is causing this problem, this is the best option right now. Closes #41
jrdh
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a tiff which when converted just causes a seg fault from Image Magick due to an assertion error. Not sure why this happens so let's just remove Image Magick from the convert function and in turn just remove it completely from the project as this was the only place it was being used. Shame as it was faster than pillow, hence why it was there, but you can't catch a seg fault and without knowing why the image is causing this problem, this is the best option right now.
The tiff I found to recreate this is this original image.
Closes #41