Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Mysql Recovery Server Resource #450

Merged
merged 6 commits into from
Sep 24, 2024
Merged

feat: Add Mysql Recovery Server Resource #450

merged 6 commits into from
Sep 24, 2024

Conversation

dusdjhyeon
Copy link
Contributor

@dusdjhyeon dusdjhyeon commented Sep 20, 2024 •
edited
Loading

mysql recovery 리소스 작성

  • mysql recovery
  • mysql recovery test
  • mysql recovery docs
user@AL02398918 terraform-provider-ncloud % go test ./internal/service/mysql/... -v -run=TestAccResourceNcloudMysqlRecovery_vpc_basic -timeout=1h
=== RUN   TestAccResourceNcloudMysqlRecovery_vpc_basic
--- PASS: TestAccResourceNcloudMysqlRecovery_vpc_basic (1492.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/mysql	1493.227s

wonchulee
wonchulee reviewed Sep 22, 2024
View reviewed changes
internal/service/mysql/mysql_recovery.go Outdated
Comment on lines 259 to 260
Pending: []string{"creating", "settingUp"},
Target: []string{"running"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상태 정보에 해당하는 "creating", "settingUp" 등의 스트링 리터럴 값은 실수를 예방하기 위해 const 변수로 정의해 사용하도록 변경해주시면 좋겠습니다.

internal/service/mysql/mysql_recovery.go Outdated
Comment on lines 298 to 299
Pending: []string{"deleting"},
Target: []string{"deleted"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(삭제도 마찬가지)

wonchulee
wonchulee approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/resources/mysql_recovery.md Outdated

# Resource: ncloud_mysql_recovery

Provides a MySQL instance resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provides a MySQL instance resource.
Provides a MySQL recovery resource.

(사소한 부분)

@wonchulee wonchulee changed the title [Feat] Add Mysql Recovery Server Resource feat: Add Mysql Recovery Server Resource Sep 23, 2024
@wonchulee wonchulee merged commit 43f26ad into NaverCloudPlatform:main Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

@youngmn youngmn Awaiting requested review from youngmn youngmn is a code owner

Assignees
No one assigned
Labels
documentation FRAMEWORK new-resource VPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusdjhyeon @wonchulee @youngmn